Skip to content

Conversation

@KostyaSha
Copy link
Contributor

@KostyaSha KostyaSha commented Dec 13, 2016

This method is called only when somebody really needs data, so no need/way with lazy InputStream reads.

CC For review @stephenc @oleg-nenashev @atanasenko


This change is Reviewable

Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
@KostyaSha
Copy link
Contributor Author

@kohsuke

@oleg-nenashev
Copy link
Collaborator

LGTM 👍

Copy link
Contributor

@stephenc stephenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KostyaSha
Copy link
Contributor Author

merge & release please

@KostyaSha
Copy link
Contributor Author

KostyaSha commented Dec 14, 2016

spof check #321

@KostyaSha
Copy link
Contributor Author

@kohsuke so could you merge and release?

@kohsuke kohsuke merged commit 0780e10 into hub4j:master Dec 17, 2016
kohsuke added a commit that referenced this pull request Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants