Add ability to update Github labels #649
Conversation
bitwiseman
left a comment
bitwiseman
left a comment
There was a problem hiding this comment.
@halkeye
Sorry, you see that there is already a setColor() and setDescription(), right?
We probably want to use the Builder/Updater pattern used elsewhere rather than adding an update() method with more parameters.
I'm open to discussing further if you have strong opinion on it.
|
I didn't. I can add set name. I think they should have fetchinto and the tests still right? |
halkeye
force-pushed
the
add-labels-update
branch
from
14db009 to
a7062c0
Compare
| * @see GHRepository#listLabels() GHRepository#listLabels() | ||
| */ | ||
| public class GHLabel { | ||
| public class GHLabel extends GHObject { |
There was a problem hiding this comment.
Does this actually have all the fields from GHObject? I don't think it does.
|
@halkeye
Yes, you kind of did - by using If someone is depending on GHLabel instances to be immutable, they will get a surprise after this change. I'm not saying it is wrong, it is just unclear what the right behavior for the library overall should be. See #589. Look I'm not trying to make your life hard, I'm glad to have more contributors. I'm happy to make time to chat in real-time, so we can get this resolved and merged. |
|
@halkeye |
|
This PR is not a priority for me, especially since I'm not sure what next steps should be. Its certainly okay to wait. |
2 participants
Description
master. Create your PR from that branch.mvn -P ci install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.