#724 broke the site goal from .github/PULL_REQUEST_TEMPLATE.md#755
Merged
bitwiseman merged 1 commit intohub4j:masterfrom Mar 26, 2020
Merged
#724 broke the site goal from .github/PULL_REQUEST_TEMPLATE.md#755bitwiseman merged 1 commit intohub4j:masterfrom
bitwiseman merged 1 commit intohub4j:masterfrom
Conversation
Member
|
It's is run in CI, but apparently doesn't report failure? |
Contributor
Author
|
Or maybe the bad nesting of tags ceased to be a warning in JDK 11, which CI seems to run for this purpose; I was using JDK 8. |
bitwiseman
approved these changes
Mar 26, 2020
Member
|
Yes, that is it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guess you should check this in CI!