Issue 828 - Add new API - Discussion #834
Conversation
|
@bitwiseman I need your help ! |
|
@cmoulliard I see your question in the issue. I'm responding. You can also ask questions in https://gitter.im/hub4j/github-api . |
…tLogin to get the org name
… get an error 404
...emock/testCreatedDiscussion/mappings/orgs_hub4j-test-org_teams_dummy-team_discussions-3.json
Show resolved
Hide resolved
Change the visibility of the fields from protected to private. Add @JacksonInject annotation. Rename html_url to htmlUrl as needed by Jackson Co-authored-by: Liam Newman <bitwiseman@gmail.com>
Remove to set the field `root` Co-authored-by: Liam Newman <bitwiseman@gmail.com>
Remove `this.root` as it is already set with the org Co-authored-by: Liam Newman <bitwiseman@gmail.com>
Add doc link to github team discussion API Co-authored-by: Liam Newman <bitwiseman@gmail.com>
Dont wrapUp using the team object Co-authored-by: Liam Newman <bitwiseman@gmail.com>
I will add |
… correct htmlUrl field
…lder - update method
bitwiseman
left a comment
bitwiseman
left a comment
There was a problem hiding this comment.
I'm going to make a commit with some changes.
You’ve done the major work, but the more I think about it the more I feel matching the structure from #724 matters. But it is not your responsibility to match my poorly documented ideas of what I want the API to look like.
I want to be clear, this is not a comment your work but a comment on my lack of clear guidance and examples.
I’ll add a commit to this PR with my changes and we can discuss them in your morning. Thanks!
|
@cmoulliard |
|
@cmoulliard Please merge upstream master into this PR. It will clean up the diff in my downstream PR. |
Done @bitwiseman |
Tweaks for batch update
2 participants
Description
Add new API for discussion : https://developer.github.com/v3/teams/discussions/#create-a-discussion
Issue: #828
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.