feat: add the mvn args for docker build, like: -P stage#4
Merged
imbajin merged 1 commit intohugegraph:masterfrom Dec 13, 2023
Merged
feat: add the mvn args for docker build, like: -P stage#4imbajin merged 1 commit intohugegraph:masterfrom
imbajin merged 1 commit intohugegraph:masterfrom
Conversation
|
|
Collaborator
Author
|
I have only published the computer related images, but not tested them. |
imbajin
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change
In release/latest, I add the build-args for the
build and pushaction, which can be use in the related dockerfileserver/loader/hubbleIn computer, I directly add the mvn args.
And I have built the
server/loader/hubble/computerin my own repo: https://github.com/aroundabout/action_demo/actionsbuild computer action
build server action
build hubble action
build loader action
And I have tested
server/loader/hubble.The computer related images are not tested.
related PR for docker file
server: apache/hugegraph#2386
hubble/loader: apache/hugegraph-toolchain#556