Make mlflow logging dir optional#1413
Merged
muellerzr merged 1 commit intohuggingface:mainfrom May 11, 2023
Merged
Conversation
Contributor
|
This should be fixed via #1403, correct me if I'm wrong. Try this by doing |
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
#1403 doesn't address this issue. The logging_dir argument should not be mandatory for the mlflow tracker (both if we use an already existing experiment or create a new one) |
muellerzr
approved these changes
May 11, 2023
Contributor
muellerzr
left a comment
muellerzr
left a comment
There was a problem hiding this comment.
Makes sense then! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we use an already existing experiment, having to specify a logging directory doesn't make sense.
If we create a new experiment, the logging dir is optional too and is picked automatically by mlflow if not provided.