Skip to content

nit: needed sanity checks for fsdp2#3499

Merged
SunMarc merged 1 commit intohuggingface:mainfrom
kmehant:fsdp2nit
Apr 11, 2025
Merged

nit: needed sanity checks for fsdp2#3499
SunMarc merged 1 commit intohuggingface:mainfrom
kmehant:fsdp2nit

Conversation

@kmehant
Copy link
Copy Markdown
Contributor

@kmehant kmehant commented Apr 11, 2025

What does this PR do?

Simle nit fixes needed for using fsdp2 in a pre-configured environment.

This has been discussed in #3394

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc or @zach-huggingface or @S1ro1

Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
@kmehant kmehant mentioned this pull request Apr 11, 2025
Copy link
Copy Markdown
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SunMarc SunMarc merged commit ee4cab9 into huggingface:main Apr 11, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants