Fix mutable default in Megatron init and IndexError on empty ModuleList#3944
Merged
SunMarc merged 2 commits intohuggingface:mainfrom Mar 2, 2026
Merged
Conversation
… ModuleList
In megatron_lm.py, initialize() used args_defaults={} as a default
parameter, which is shared across calls and can cause unexpected
state persistence.
In other.py, is_repeated_block() accessed module[0] without checking
if the ModuleList was empty, causing IndexError for empty ModuleLists.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
@bot /style |
Contributor
|
Style bot fixed some files and pushed the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two bugs:
utils/megatron_lm.py-initialize()usedargs_defaults={}as a default parameter. Mutable defaults are shared across calls, so any mutation persists into subsequent invocations.utils/other.py-is_repeated_block()accessedmodule[0]without checking if theModuleListwas empty. An emptyModuleListwould raiseIndexErrorbefore theall()check could short-circuit.