Fix: Conditionally import torch.distributed.algorithms.join in accelerator.py#3962
Merged
SunMarc merged 1 commit intohuggingface:mainfrom Mar 11, 2026
Merged
Conversation
torch.distributed.algorithms.join in accelerator.py
torch.distributed.algorithms.join in accelerator.pytorch.distributed.algorithms.join in accelerator.py
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
@SunMarc huggingface/transformers#44507 was recently merged. This one should be good to go as well. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
torch.distributedis not available in all PyTorch builds (for example, Windows ROCm). Importingtorch.distributed.algorithms.join.Joinunconditionally at the top level ofaccelerator.pycauses an immediate crash with:This makes
import acceleratefail entirely on those builds, even for users who have no intention of using distributed training.Changes
from torch.distributed.algorithms.join import Joininif torch.distributed.is_available():Joinis only used insidejoin_uneven_inputs()which is documented as multi-GPU DDP only, so this guard is safe and consistent with how the rest of the file handles optional distributed functionalityPrior art
The same fix was applied to
huggingface/diffusersin:A previous fix for the same class of issue in
huggingface/transformerswas made in:Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@SunMarc