-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[scheduler] Support custom sigmas/timesteps in UniPCMultistepScheduler #12109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
I think it's working: import torch
from diffusers import QwenImagePipeline, UniPCMultistepScheduler
pipe = QwenImagePipeline.from_pretrained("Qwen/Qwen-Image", torch_dtype=torch.bfloat16)
pipe.scheduler = UniPCMultistepScheduler.from_config(pipe.scheduler.config, prediction_type="flow_prediction", use_flow_sigmas=True)
pipe.to("cuda")
prompt = """A coffee shop entrance features a chalkboard sign reading "Qwen Coffee 😊 $2 per cup," with a neon light beside it displaying "通义千问". Next to it hangs a poster showing a beautiful Chinese woman, and beneath the poster is written "π≈3.1415926-53589793-23846264-33832795-02384197". Ultra HD, 4K, cinematic composition."""
image = pipe(prompt, negative_prompt=" ", width=1664, height=928, num_inference_steps=30, generator=torch.Generator().manual_seed(42)).images[0]
image.save("output.png")
cc @asomoza in case you want to do some tests |
|
Gentle ping @yiyixuxu |
|
Ping that having this support would be sooooo helpful! |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@dg845 can you take a look here? |
|
Hi @yiyixuxu, could you take a look at this PR? I think it is close to being merged. |
|
thanks for worrking on this! |
yiyixuxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
I left one question, I think if we don't support custom timesteps the logic would look much better/simpler
but let me know what you think
| device: Union[str, torch.device] = None, | ||
| mu: Optional[float] = None, | ||
| sigmas: Optional[List[float]] = None, | ||
| timesteps: Optional[List[float]] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe we don't need to support custom timesteps here
It was introduced in some pipeline for AYS and much less common use case




Fixes #12108
The quality is not great, not sure why yet. Still needs debugging.
cc @Vargol