-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Modular] implement requirements validation for custom blocks #12196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+291
−5
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
12ceecf
feat: implement requirements validation for custom blocks.
sayakpaul 127e9a3
up
sayakpaul 37d3887
unify.
sayakpaul d2731ab
Merge branch 'main' into requirements-custom-blocks
sayakpaul 756a156
Merge branch 'main' into requirements-custom-blocks
sayakpaul d159ae0
Merge branch 'main' into requirements-custom-blocks
sayakpaul ecbd907
Merge branch 'main' into requirements-custom-blocks
sayakpaul b7fba89
Merge branch 'main' into requirements-custom-blocks
sayakpaul 046be83
up
sayakpaul 2c4d73d
Merge branch 'main' into requirements-custom-blocks
sayakpaul e52cabe
Merge branch 'main' into requirements-custom-blocks
sayakpaul 35d8d97
Merge branch 'main' into requirements-custom-blocks
sayakpaul 024c2b9
Merge branch 'main' into requirements-custom-blocks
sayakpaul 1de4402
up
sayakpaul 5b7d0df
Merge branch 'main' into requirements-custom-blocks
sayakpaul eeb3445
Merge branch 'main' into requirements-custom-blocks
sayakpaul a9165eb
Merge branch 'main' into requirements-custom-blocks
sayakpaul a88d11b
resolve conflicts.
sayakpaul 3879e32
Merge branch 'main' into requirements-custom-blocks
sayakpaul 7b43d0e
add tests
sayakpaul 60e3284
Merge branch 'main' into requirements-custom-blocks
sayakpaul 79fa0e2
resolve merge conflicts.
sayakpaul 445c42e
Merge branch 'main' into requirements-custom-blocks
sayakpaul 2927353
Apply suggestions from code review
sayakpaul e8d4612
reviewer feedback.
sayakpaul 2504341
Merge branch 'main' into requirements-custom-blocks
sayakpaul f274df4
[docs] validation for custom blocks (#13156)
stevhliu 5316fe2
Merge branch 'main' into requirements-custom-blocks
sayakpaul ba73d82
Merge branch 'main' into requirements-custom-blocks
sayakpaul d8839bb
Merge branch 'main' into requirements-custom-blocks
sayakpaul 6ddc168
move to tmp_path fixture.
sayakpaul 2f32021
propagate to conditional and loopsequential blocks.
sayakpaul fa64a93
up
sayakpaul a182277
remove collected tests
sayakpaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add the same
_requirementsproperty toConditionalPipelineBlocks& others?right now, unless it's all
SequentialPipelineBlocks, the nested requirements get lost, no?block_a's subblock requirement will be lost
the algo might be a bit aggresive for conditional blocks (we'd collect from all branches even though the user may only want to run one), but since this is warn-only I think that's fine
In practice, I think we'd recommend people override
_requirementsdirectly on their final block class rather than relying on the auto-accumulation, but good to have a default and have this meta data