cogvideo example: Distribute VAE video encoding across processes in CogVideoX LoRA training#13207
Merged
sayakpaul merged 2 commits intohuggingface:mainfrom Mar 4, 2026
Merged
Conversation
sayakpaul
approved these changes
Mar 4, 2026
Member
|
@bot /style |
Contributor
|
Style bot fixed some files and pushed the changes. |
Member
|
Thanks for your contributions! |
…ning Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, every process encodes the entire dataset through the VAE during preprocessing. This is redundant in multi-GPU training — each process does the same full encoding work independently.
This PR shards the VAE encoding across processes so that each process only encodes 1/num_processes of the videos, then broadcasts the results. This reduces the preprocessing time proportionally to the number of processes (e.g., ~4x faster with 4 GPUs) with no change to training behavior.
Single-GPU training is unaffected.
Hi @sayakpaul . Would you please review this PR? Thanks!