Skip to content

dreambooth: fix #1566: maintain fp32 wrapper when saving a checkpoint to avoid crash when running fp16 #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickvonplaten merged 4 commits into from
Dec 10, 2022
Merged

dreambooth: fix #1566: maintain fp32 wrapper when saving a checkpoint to avoid crash when running fp16 #1618

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80486c1
dreambooth: fix #1566: maintain fp32 wrapper when saving a checkpoint…
timh Dec 6, 2022
ebfd8bf
dreambooth: guard against passing keep_fp32_wrapper arg to older vers…
timh Dec 8, 2022
7d039df
Apply suggestions from code review
patrickvonplaten Dec 10, 2022
94bd34d
Update examples/dreambooth/train_dreambooth.py
patrickvonplaten Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions examples/dreambooth/train_dreambooth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import argparse
import hashlib
import inspect
import itertools
import math
import os
Expand Down Expand Up @@ -690,10 +691,19 @@ def main(args):

if global_step % args.save_steps == 0:
if accelerator.is_main_process:
# When 'keep_fp32_wrapper' is `False` (the default), then the models are
# unwrapped and the mixed precision hooks are removed, so training crashes
# when the unwrapped models are used for further training.
# This is only supported in newer versions of `accelerate`.
# TODO(Pedro, Suraj): Remove `accepts_keep_fp32_wrapper` when forcing newer accelerate versions
accepts_keep_fp32_wrapper = "keep_fp32_wrapper" in set(
inspect.signature(accelerator.unwrap_model).parameters.keys()
)
extra_args = {"keep_fp32_wrapper": True} if accepts_keep_fp32_wrapper else {}
pipeline = DiffusionPipeline.from_pretrained(
args.pretrained_model_name_or_path,
unet=accelerator.unwrap_model(unet),
text_encoder=accelerator.unwrap_model(text_encoder),
unet=accelerator.unwrap_model(unet, **extra_args),
text_encoder=accelerator.unwrap_model(text_encoder, **extra_args),
revision=args.revision,
)
save_path = os.path.join(args.output_dir, f"checkpoint-{global_step}")
Expand Down