Skip to content

Update train_dreambooth_colossalai.py#1977

Closed
haofanwang wants to merge 6 commits intohuggingface:mainfrom
haofanwang:patch-2
Closed

Update train_dreambooth_colossalai.py#1977
haofanwang wants to merge 6 commits intohuggingface:mainfrom
haofanwang:patch-2

Conversation

@haofanwang
Copy link
Copy Markdown
Contributor

@haofanwang haofanwang commented Jan 11, 2023

Fix a known bug in this example. From a recent update in colossalai.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Jan 11, 2023

The documentation is not available anymore as the PR was closed or merged.

@haofanwang
Copy link
Copy Markdown
Contributor Author

@patrickvonplaten This update has been merged into ColossalAI, it should be fine to merge into diffusers.

@patrickvonplaten
Copy link
Copy Markdown
Contributor

patrickvonplaten commented Jan 13, 2023

Hey @haofanwang,

Could you maybe run:

make style

once to fix the failing test?

@haofanwang
Copy link
Copy Markdown
Contributor Author

Already done. But it seems that the testing is still fail? @patrickvonplaten

@isamu-isozaki
Copy link
Copy Markdown
Contributor

@haofanwang I noticed that when you run the style check it modifies the other parts of the code too which causes the tests to fail interestingly enough. So I recommend doing git add on just the colossalai part and nothing else. Then I think it should be fixed.

@haofanwang
Copy link
Copy Markdown
Contributor Author

Thanks. Will fix this in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants