stable diffusion depth batching fix #2757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamberman
commented
Mar 20, 2023
Comment on lines
-477
to
+478
| depth_map = depth_map.repeat(batch_size, 1, 1, 1) | ||
| repeat_by = batch_size // depth_map.shape[0] | ||
| depth_map = depth_map.repeat(repeat_by, 1, 1, 1) |
Contributor
Author
There was a problem hiding this comment.
This will cause a mismatch in the batch dimension when using a batch size > 1 and a num_images_per_prompt > 1
It's always repeating by total batch size even if the depth_map already is batched
Member
There was a problem hiding this comment.
Good catch! Maybe having it as a comment would be helpful for us in recollecting why this was needed.
williamberman
requested review from
patil-suraj,
patrickvonplaten,
pcuenca and
sayakpaul
|
The documentation is not available anymore as the PR was closed or merged. |
sayakpaul
reviewed
Mar 21, 2023
| params = TEXT_GUIDED_IMAGE_VARIATION_PARAMS - {"height", "width"} | ||
| required_optional_params = PipelineTesterMixin.required_optional_params - {"latents"} | ||
| batch_params = TEXT_GUIDED_IMAGE_VARIATION_BATCH_PARAMS - {"image"} | ||
| batch_params = TEXT_GUIDED_IMAGE_VARIATION_BATCH_PARAMS |
patrickvonplaten
approved these changes
Mar 21, 2023
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Super thanks for the fix!
w4ffl35
pushed a commit
to w4ffl35/diffusers
that referenced
this pull request
Apr 14, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.