[WIP][DRAFT] PEFT integration#4780
Closed
younesbelkada wants to merge 10 commits intohuggingface:mainfrom
Closed
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Contributor
|
@younesbelkada @sayakpaul should we maybe first merge a PR that just removes the LoRA logic for the text encoder and only in a next PR we tackle the UNet? I feel like otherwise the PRs are getting too complex. |
Contributor
Author
|
Sure yes, let me open a separate PR that includes only the commits of text encoder and leave this PR for Unet |
This was referenced Sep 15, 2023
6 tasks
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @sayakpaul @pacman100 @BenjaminBossan @patrickvonplaten
needs huggingface/transformers#25721
To test it, install that branch + peft main and run:
Currently on main branch, this should give without scale:
With scale = 0.5:
TODOs: