-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix bug in StableDiffusionXLControlNetPipeline when use guess_mode #4799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
Cool! One quick fast/dummy test for this one? |
|
Very nice! Looks good to me - let's maybe add this also to our SDXL controlnet docs in a follow-up PR (cc @stevhliu) Think the test is also currently failing on the CI - can we make it more deterministic? |
…ers into sdxl-controlnet-guess
patrickvonplaten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! @sayakpaul maybe for a final review?
sayakpaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic definitely reads simplistic now. Thank you!
…uggingface#4799) * fix --------- Co-authored-by: yiyixuxu <yixu310@gmail,com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
…uggingface#4799) * fix --------- Co-authored-by: yiyixuxu <yixu310@gmail,com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
This PR fix a bug in sdxl controlnet when
guess_mode=TrueIt fix #4709 and I think it does the same thing as #4155 but we don't need to drastically change the code structure