-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Add StableDiffusionXLControlNetInpaintPipeline #4811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/diffusers/pipelines/stable_diffusion_xl/pipeline_stable_diffusion_xl_controlnet_inpaint.py
Outdated
Show resolved
Hide resolved
patrickvonplaten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add some tests?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Sure. |
|
is this same as #4694 ? |
They are similar but not the same. This PR mainly adapted from src/diffusers/pipelines/stable_diffusion_xl/pipeline_stable_diffusion_xl_inpaint.py, so it has the same coding style with pipeline_stable_diffusion_xl series. #4694 mainly adapted from controlnet, so it may have more similar class structure with controlnet instead of stable_diffusion_xl. |
|
Thanks for the work. I have tried to use the newly introduced class in this PR, but in my experiments, the inpainting result is often not compatible with the context. I'm using depth condition though. |
|
cc @harutatsuakiyama here We only need one inpaiting pipeline for SDXL so it would be great if you guys could work together! We can make sure you are both the author of the same PR:) I think since we have already reviewed this PR #4694, maybe we will continue to work on this PR? @viiika would you be willing to review it too and point out things that you implemented in your PR but are missing there? or, you guys decide to go with this PR that would be totally fine too! Thanks YiYi |
Thank you @yiyixuxu. I am more than happy to work in conjunction with @viiika. |
What does this PR do?
Fixes # (issue)
Add a new class StableDiffusionXLControlNetInpaintPipeline() for using SDXL Inpaint Model with ControlNets.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.