Register BaseOutput subclasses as supported torch.utils._pytree nodes#5459
Merged
DN6 merged 3 commits intohuggingface:mainfrom Oct 24, 2023
Merged
Register BaseOutput subclasses as supported torch.utils._pytree nodes#5459DN6 merged 3 commits intohuggingface:mainfrom
DN6 merged 3 commits intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
DN6
approved these changes
Oct 20, 2023
Collaborator
DN6
left a comment
DN6
left a comment
There was a problem hiding this comment.
LGTM. Can merge once CI is green 👍🏽
Collaborator
|
@BowenBao Could you run |
patrickvonplaten
approved these changes
Oct 23, 2023
BowenBao
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 24, 2023
…diffusers' in dynamo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
BowenBao
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 24, 2023
…namo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
BowenBao
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 26, 2023
…diffusers' in dynamo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
BowenBao
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 26, 2023
…namo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
BowenBao
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 27, 2023
…' and subclasses from 'diffusers' in dynamo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
BowenBao
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 27, 2023
… from 'diffusers' in dynamo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
BowenBao
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 30, 2023
…diffusers' in dynamo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
BowenBao
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 30, 2023
…namo" Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 30, 2023
Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. Pull Request resolved: #111978 Approved by: https://github.com/jansel
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…ch#111978) Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. Pull Request resolved: pytorch#111978 Approved by: https://github.com/jansel
kashif
pushed a commit
to kashif/diffusers
that referenced
this pull request
Nov 11, 2023
…huggingface#5459) * Register BaseOutput subclasses as supported torch.utils._pytree nodes * lint --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ch#111978) Extending the workarounds for `transformers` `ModelOutput` to cover `diffusers` `BaseOutput`. Together with huggingface/diffusers#5459 it should unblock export for `diffusers` models. Pull Request resolved: pytorch#111978 Approved by: https://github.com/jansel
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…huggingface#5459) * Register BaseOutput subclasses as supported torch.utils._pytree nodes * lint --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…huggingface#5459) * Register BaseOutput subclasses as supported torch.utils._pytree nodes * lint --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Identical to huggingface/transformers#25358, this PR should unblock the similar issue. Additionally, this, among other fixes, aims to unblock PT2 exports for models that outputs
BaseOutputsubclasses.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.