fix: use correct py.typed location in setup#5610
Closed
niqodea wants to merge 1 commit intohuggingface:mainfrom
Closed
fix: use correct py.typed location in setup#5610niqodea wants to merge 1 commit intohuggingface:mainfrom
niqodea wants to merge 1 commit intohuggingface:mainfrom
Conversation
Author
|
Never mind, it seems like the original repository is already ok when including it via git. |
Author
|
For context, this problem is already addressed by #5326. I erroneously thought the code was already included in the latest release 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use correctpy.typedlocation insetup.py, accounting for the missingsrc/diffuserspart.When trying topoetry install diffusers, Mypy still complains about missing stubs. In fact, I could not findpy.typedin the library after installation. By using the absolute path topy.typedfrom the repo root, this problem seems fixed.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed.