Skip to content

[LoRA depcrecation] LoRA depcrecation trilogy #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sayakpaul merged 7 commits into from
Jan 5, 2024
Merged

[LoRA depcrecation] LoRA depcrecation trilogy #6450

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3cae4d4
edebug
sayakpaul Jan 4, 2024
a5e2fce
debug
sayakpaul Jan 4, 2024
321fbf3
more debug
sayakpaul Jan 4, 2024
3870dec
more more debug
sayakpaul Jan 4, 2024
4ed8a51
remove tests for LoRAAttnProcessors.
sayakpaul Jan 4, 2024
c89cecf
rename
sayakpaul Jan 4, 2024
415024a
Merge branch 'main' into lora-depcrecation-trilogy
sayakpaul Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions tests/lora/test_lora_layers_old_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1496,7 +1496,7 @@ def prepare_init_args_and_inputs_for_common(self):
inputs_dict = self.dummy_input
return init_dict, inputs_dict

def test_lora_processors(self):
def test_lora_at_different_scales(self):
# enable deterministic behavior for gradient checkpointing
init_dict, inputs_dict = self.prepare_init_args_and_inputs_for_common()

Expand All @@ -1514,9 +1514,6 @@ def test_lora_processors(self):
model.load_attn_procs(lora_params)
model.to(torch_device)

# test that attn processors can be set to itself
model.set_attn_processor(model.attn_processors)

with torch.no_grad():
sample2 = model(**inputs_dict, cross_attention_kwargs={"scale": 0.0}).sample
sample3 = model(**inputs_dict, cross_attention_kwargs={"scale": 0.5}).sample
Expand Down Expand Up @@ -1595,7 +1592,7 @@ def test_lora_xformers_on_off(self, expected_max_diff=6e-4):


@deprecate_after_peft_backend
class UNet3DConditionModelTests(unittest.TestCase):
class UNet3DConditionLoRAModelTests(unittest.TestCase):
model_class = UNet3DConditionModel
main_input_name = "sample"

Expand Down Expand Up @@ -1638,7 +1635,7 @@ def prepare_init_args_and_inputs_for_common(self):
inputs_dict = self.dummy_input
return init_dict, inputs_dict

def test_lora_processors(self):
def test_lora_at_different_scales(self):
init_dict, inputs_dict = self.prepare_init_args_and_inputs_for_common()

init_dict["attention_head_dim"] = 8
Expand All @@ -1655,9 +1652,6 @@ def test_lora_processors(self):
model.load_attn_procs(unet_lora_params)
model.to(torch_device)

# test that attn processors can be set to itself
model.set_attn_processor(model.attn_processors)

with torch.no_grad():
sample2 = model(**inputs_dict, cross_attention_kwargs={"scale": 0.0}).sample
sample3 = model(**inputs_dict, cross_attention_kwargs={"scale": 0.5}).sample
Expand Down