Escpaing of svelte characters inside doc body only#417
Merged
Conversation
mishig25
added a commit
to huggingface/course
that referenced
this pull request
Sep 27, 2023
testing testing huggingface/doc-builder#417
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With #401, we are escaping
{so that it gets treated as string rather than inline svelte js. However, that caused line below to get treated as literal string rather than jsdoc-builder/kit/src/lib/DropdownEntry.svelte
Line 40 in 787f9af
Solution
Escape
{,<only in user written markdown doc. Don't escape for svelte components (i.e. treat{as regular svelte inline js)