kernel-builder: use tag argument instead of rev for tags in fetchFromGitHub#432
Merged
danieldk merged 1 commit intohuggingface:mainfrom Apr 9, 2026
Merged
kernel-builder: use tag argument instead of rev for tags in fetchFromGitHub#432danieldk merged 1 commit intohuggingface:mainfrom
danieldk merged 1 commit intohuggingface:mainfrom
Conversation
…GitHub The tag argument is prefixed with refs/tags/ to construct the full rev in fetchgit[1], preventing rev confusion (e.g. where a branch and a tag have the same name), thus it's recommended to use the tag argument over the rev argument for tags. [1] https://github.com/NixOS/nixpkgs/blob/55d32361d6c1f304e6c88a0dbebb19fb1044bbd7/pkgs/build-support/fetchgit/default.nix#L31 Signed-off-by: Nick Cao <ncao@redhat.com>
danieldk
approved these changes
Apr 9, 2026
Member
danieldk
left a comment
danieldk
left a comment
There was a problem hiding this comment.
Yeah, I always forget using tag, old habits. Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tag argument is prefixed with refs/tags/ to construct the full rev in fetchgit[1], preventing rev confusion (e.g. where a branch and a tag have the same name), thus it's recommended to use the tag argument over the rev argument for tags.
[1] https://github.com/NixOS/nixpkgs/blob/55d32361d6c1f304e6c88a0dbebb19fb1044bbd7/pkgs/build-support/fetchgit/default.nix#L31