Catch ROCM/HIP/AMD oom in should_reduce_batch_size#812
Merged
clefourrier merged 3 commits intohuggingface:mainfrom Jun 23, 2025
Merged
Catch ROCM/HIP/AMD oom in should_reduce_batch_size#812clefourrier merged 3 commits intohuggingface:mainfrom
should_reduce_batch_size#812clefourrier merged 3 commits intohuggingface:mainfrom
Conversation
clefourrier
approved these changes
Jun 20, 2025
Member
clefourrier
left a comment
clefourrier
left a comment
There was a problem hiding this comment.
hi, thanks for change, lgtm
Collaborator
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
Hi, can you fix the code style? |
Contributor
Author
|
Should be formatted right now |
Member
|
Perf, thanks! |
NathanHB
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Catch ROCM/HIP oom in should_reduce_batch_size * fix formatting --------- Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ROCM/HIP/AMD oom message is missing from
should_reduce_batch_sizein utils meaning that an OOM occurs during start up on AMD GPUs. Super simple fix :)