set default temperature to 0 in generation config#814
Merged
clefourrier merged 3 commits intomainfrom Jun 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GenerationParameters model to default temperature to 0 (greedy decoding) instead of None.
- Changed
temperaturefromNonNegativeFloat | None = NonetoNonNegativeFloat = 0 - Removed support for
Noneas a temperature value - Added inline comment clarifying default greedy decoding behavior
Comments suppressed due to low confidence (3)
src/lighteval/models/model_input.py:39
- Changing the default for
temperaturefromNoneto0is a breaking API change; consider documenting this in the CHANGELOG and bumping the version or adding a deprecation note for the old behavior.
temperature: NonNegativeFloat = (
src/lighteval/models/model_input.py:39
- Add or update unit tests to cover the new default
temperature=0behavior and verify that greedy decoding is triggered when no custom value is provided.
temperature: NonNegativeFloat = (
src/lighteval/models/model_input.py:40
- Update the class docstring or external documentation to reflect that
temperaturenow defaults to0and that passingNoneis no longer supported.
0 # vllm, transformers, tgi, litellm, sglang # if not set, defaults to greedy decoding
Collaborator
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
* set default temperature to 0 in generation config * issue warning when temperature == 0 with multiple samples * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.