Skip to content

Fix system prompt concatenated with instruction in chat template #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewtun merged 1 commit into from
Jun 24, 2025
+4 −4
Merged

Fix system prompt concatenated with instruction in chat template #830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/lighteval/tasks/prompt_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,10 +310,10 @@ def get_examples( # noqa: C901

# System prompt and instruction
if use_chat_template:
if system_prompt is not None: # We add system prompt and instruction jointly if possible
examples.insert(0, {"role": "system", "content": system_prompt + instruction})
else: # Else we add the instruction to the first example
examples[0]["content"] = instruction + examples[0]["content"]
# We add the instruction to the first example
examples[0]["content"] = instruction + examples[0]["content"]
if system_prompt is not None: # We add system prompt if available
examples.insert(0, {"role": "system", "content": system_prompt})
return examples
else:
system_prompt = system_prompt if system_prompt is not None else ""
Expand Down
Loading