fix lighteval task inspect command and tiny bench task#992
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the lighteval task inspect command and resolves issues in the tiny benchmark task implementation. The changes address API signature mismatches and syntax errors that were preventing proper functionality.
Key changes:
- Updates method signatures to match the expected API contract for sample and corpus level computations
- Fixes syntax error in ifbench prime number set definition
- Restructures metrics initialization to avoid circular dependency issues
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lighteval/tasks/extended/tiny_benchmarks/main.py | Updates compute method signatures, fixes metrics initialization pattern, and removes circular enum extension |
| src/lighteval/tasks/extended/ifbench/instructions.py | Fixes syntax error in prime number set definition |
| src/lighteval/metrics/metrics_sample.py | Standardizes parameter order in abstract method signature |
| src/lighteval/metrics/metrics_corpus.py | Adds missing items parameter to abstract method signature |
| src/lighteval/main_tasks.py | Fixes task registry initialization and config attribute access |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
rolshoven
pushed a commit
to rolshoven/lighteval
that referenced
this pull request
Mar 17, 2026
…#992) * fix * revert uneeded changes --------- Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.