update quantization configurations for ryzenai (vai_q_onnx)#117
Merged
mht-sharma merged 5 commits intohuggingface:add_quantization_optionsfrom May 27, 2024
Merged
Conversation
Contributor
|
Hi @ChaoLi-AMD is this the final changes agreed in the meeting? |
Contributor
Author
This is the first step discussed in the meeting, where we changed the enum to a string. There will be further alignment in the future. |
Contributor
|
Thanks @ChaoLi-AMD, could you also resolve the conflicts. @Giuseppe5 would you like to review the PR as we discussed |
Contributor
|
Looks good to me! |
Contributor
Author
|
Hi Mohit, is this PR ready to be merged? @mht-sharma |
mht-sharma
approved these changes
May 27, 2024
Contributor
mht-sharma
left a comment
mht-sharma
left a comment
There was a problem hiding this comment.
Sorry for the delay @ChaoLi-AMD . This LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.