[RyzenAI] Add default config#122
Conversation
fxmarty
left a comment
There was a problem hiding this comment.
Great work, left a few small comments!
| @@ -0,0 +1,306 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we clarify with AMD the license compatibility of this file? I think the license is https://account.amd.com/content/dam/account/en/licenses/download/eula-beta-software.pdf which may not be compatible.
There was a problem hiding this comment.
I think this file here is copied from voe-4.0-wind_amd64. Alternatively https://github.com/amd/RyzenAI-SW/blob/main/example/Ryzen-AI-Library/windows/vaip_config.json may be used which I guess is under MIT (?) ?
There was a problem hiding this comment.
I have asked the question to Sumit.
Although the config is same as https://github.com/amd/RyzenAI-SW/blob/main/tutorial/yolov8_e2e/vaip_config.json, which is under MIT license. So should not be an issue.
There was a problem hiding this comment.
yes we are releasing this out, so it's ok to have it here too.
As per title.
User can now skip providing the
vaip_configas an argument. The model will use default config if none providedThis would allow to truly adapt to the existing
transformersinterface by just replacing class.