Skip to content

[RyzenAI] Add default config#122

Merged
mht-sharma merged 5 commits intomainfrom
add_default_cfgs
Mar 28, 2024
Merged

[RyzenAI] Add default config#122
mht-sharma merged 5 commits intomainfrom
add_default_cfgs

Conversation

@mht-sharma
Copy link
Copy Markdown
Contributor

@mht-sharma mht-sharma commented Mar 21, 2024

As per title.

User can now skip providing the vaip_config as an argument. The model will use default config if none provided

This would allow to truly adapt to the existing transformers interface by just replacing class.

- model = AutoModelForImageClassification.from_pretrained(model_id)
+ model = RyzenAIModelForImageClassification.from_pretrained(model_id)

@mht-sharma mht-sharma changed the title Add default config [RyzenAI] Add default config Mar 26, 2024
@mht-sharma mht-sharma mentioned this pull request Mar 26, 2024
5 tasks
@fxmarty fxmarty self-requested a review March 26, 2024 11:50
Copy link
Copy Markdown
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, left a few small comments!

Comment thread docs/source/ryzenai/overview.mdx
@@ -0,0 +1,306 @@
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clarify with AMD the license compatibility of this file? I think the license is https://account.amd.com/content/dam/account/en/licenses/download/eula-beta-software.pdf which may not be compatible.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file here is copied from voe-4.0-wind_amd64. Alternatively https://github.com/amd/RyzenAI-SW/blob/main/example/Ryzen-AI-Library/windows/vaip_config.json may be used which I guess is under MIT (?) ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have asked the question to Sumit.

Although the config is same as https://github.com/amd/RyzenAI-SW/blob/main/tutorial/yolov8_e2e/vaip_config.json, which is under MIT license. So should not be an issue.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine then!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we are releasing this out, so it's ok to have it here too.

Comment thread optimum/amd/ryzenai/modeling.py Outdated
Comment thread optimum/amd/ryzenai/modeling.py Outdated
Comment thread optimum/amd/ryzenai/utils.py Outdated
Comment thread optimum/amd/ryzenai/utils.py Outdated
@mht-sharma mht-sharma merged commit 18a92f9 into main Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants