FIX: Adjust transformers version check for bloom#1992
Merged
BenjaminBossan merged 2 commits intohuggingface:mainfrom Aug 6, 2024
Merged
Conversation
See huggingface#1969 The fix to the bloom architecture was not actually released in transformers 4.43.3, which makes the version check invalid. Instead, now checking an attribute on the BloomPreTrainedModel.
> is a more general check for all models, so might be more preferred for tests
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
The fix to the bloom architecture was not actually released in transformers 4.43.3, which makes the version check invalid. Instead, now checking an attribute on the BloomPreTrainedModel.
cyyever
pushed a commit
to cyyever/peft
that referenced
this pull request
Sep 4, 2025
* adds cli and import utils * updates SFT script * adds liger model to trainer * adds liger nightly dep * precommit * fix import * Update trl/commands/cli_utils.py * Fix quality * moved use_liger arg to sft config * remove arg * remove use liger from sft trainer --------- Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1969
The fix to the bloom architecture was not actually released in transformers 4.43.3, which makes the version check invalid. Instead, now checking an attribute on the
BloomPreTrainedModel.