[WIP] Support transformers weight conversion#2995
Closed
BenjaminBossan wants to merge 2 commits intohuggingface:mainfrom
Closed
[WIP] Support transformers weight conversion#2995BenjaminBossan wants to merge 2 commits intohuggingface:mainfrom
BenjaminBossan wants to merge 2 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
githubnemo
reviewed
Jan 15, 2026
Comment on lines
+269
to
+270
| # if target_modules is a string (=> regex), the required conversion is not trivial, we don't deal with this case | ||
| # for now |
Collaborator
There was a problem hiding this comment.
For the string case it is possible to load the model, get all lora layer names and therefore convert the regex to a list of names
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
Member
Author
|
not stale |
githubnemo
pushed a commit
to githubnemo/peft
that referenced
this pull request
Feb 27, 2026
Continuation of PR huggingface#2995. Background: huggingface/transformers#42491 and huggingface/transformers#43261. This change implements conversion operations for converting some existing PEFT checkpoints, mainly dealing with the fusing of MoE layers in transformers v5. The code added here is currently a copy from the code that exists in transformers which is supposed to be gated as soon PEFT v0.19 is released and use the code in this PR. The copying makes testing a bit difficult since there's currently no routing depending on the PEFT version in transformers. Older transformers versions, therefore, need patching to forcefully use the PEFT implementation of the conversion. As soon as the routing is implemented in transformers we can conditionally disable the patching.
Member
Author
|
Superseded by #3071. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See huggingface/transformers#42491 and huggingface/transformers#43261.