Skip to content

[WIP] CLIP#10426

Closed
patil-suraj wants to merge 10 commits intohuggingface:masterfrom
patil-suraj:clip
Closed

[WIP] CLIP#10426
patil-suraj wants to merge 10 commits intohuggingface:masterfrom
patil-suraj:clip

Conversation

@patil-suraj
Copy link
Copy Markdown
Contributor

@patil-suraj patil-suraj commented Feb 26, 2021

What does this PR do?

This PR adds OpenAI's CLIP model.
original repo: https://github.com/openai/CLIP
initial demo: https://colab.research.google.com/drive/1hwiCuKvw7hwSlE8yv7J1dh280PlYgPef?usp=sharing

@patil-suraj patil-suraj changed the title CLIP [WIP]CLIP Feb 26, 2021
@patil-suraj patil-suraj changed the title [WIP]CLIP [WIP] CLIP Feb 26, 2021
@patil-suraj patil-suraj marked this pull request as draft February 26, 2021 21:36
@dribnet
Copy link
Copy Markdown
Contributor

dribnet commented Mar 11, 2021

Awesome effort. Is the current version already compatible with (now merged) #10594 ?

@patil-suraj
Copy link
Copy Markdown
Contributor Author

Thanks @dribnet

I haven't added a feature extractor class for CLIP yet. We first need to finish the ImageFeatureExtractor (#1608)
Then the ClipFeatureExtractor can inherit from that. This PR will be ready to merge by the end of next week.

@github-actions
Copy link
Copy Markdown
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@LysandreJik
Copy link
Copy Markdown
Member

Unstale

@LysandreJik LysandreJik added the WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress label Apr 14, 2021
@patil-suraj
Copy link
Copy Markdown
Contributor Author

continuing this in #11445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants