Skip to content

Sagemaker test fix#10987

Merged
LysandreJik merged 2 commits intomasterfrom
sagemaker-test-fix
Mar 31, 2021
Merged

Sagemaker test fix#10987
LysandreJik merged 2 commits intomasterfrom
sagemaker-test-fix

Conversation

@philschmid
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixed test documentation makefile command and PyTorch-ddp test when #10975 is merged. Different validation function for sagemaker-data-parallel. Can be merged already.

@philschmid philschmid requested a review from LysandreJik March 31, 2021 09:41
Copy link
Copy Markdown
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@LysandreJik LysandreJik merged commit ced7284 into master Mar 31, 2021
@LysandreJik LysandreJik deleted the sagemaker-test-fix branch March 31, 2021 11:44
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
* wrong makefile command

* ddp test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants