Fixed: Better names for nlp variables in pipelines' tests and docs.#11752
Merged
sgugger merged 3 commits intohuggingface:masterfrom May 18, 2021
Merged
Fixed: Better names for nlp variables in pipelines' tests and docs.#11752sgugger merged 3 commits intohuggingface:masterfrom
sgugger merged 3 commits intohuggingface:masterfrom
Conversation
sgugger
approved these changes
May 17, 2021
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Amazing, thanks a lot for doing this!
LysandreJik
approved these changes
May 18, 2021
Collaborator
|
Could you take care of the merge conflicts and we should be good to merge? Thanks! |
…into transformers-9455
Contributor
|
Thanks a lot for this ! |
Iwontbecreative
pushed a commit
to Iwontbecreative/transformers
that referenced
this pull request
Jul 15, 2021
…uggingface#11752) * Fixed: Better names for nlp variables in pipelines' tests and docs. * Fixed: Better variable names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9455
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Narsil @sgugger