Skip to content

Fix regression in regression#11785

Merged
sgugger merged 2 commits intomasterfrom
fix_regression
May 20, 2021
Merged

Fix regression in regression#11785
sgugger merged 2 commits intomasterfrom
fix_regression

Conversation

@sgugger
Copy link
Copy Markdown
Collaborator

@sgugger sgugger commented May 20, 2021

What does this PR do?

This PR fixes the regression introduced in #11012 for regression problems with only one label (like STS-B), see discussion on #11780. I checked both run_glue and run_glue_no_trainer on this branch and get the proper results for this task now.

Fixes #11780
Fixes #11583

@sgugger sgugger requested a review from LysandreJik May 20, 2021 13:23
Copy link
Copy Markdown
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM, thanks!

Copy link
Copy Markdown
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test!

@sgugger sgugger merged commit 469384a into master May 20, 2021
@sgugger sgugger deleted the fix_regression branch May 20, 2021 13:55
@yoshitomo-matsubara
Copy link
Copy Markdown
Contributor

Thank you for fixing the issue!

Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
* Fix regression in regression

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unintentional(?) interface change on loss function in models didn't work well for single-column regression Wrong results for GLUE task STS-B

3 participants