electra is added to onnx supported model#15084
electra is added to onnx supported model#15084lewtun merged 13 commits intohuggingface:masterfrom aaron-dunamu:electra-onnx-support
Conversation
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Thank you for this very clean PR @arron1227 🔥 !
Overall it looks great 😃. Could you please:
- add an Electra checkpoint to
test_onnx_v2.pyhere. I would try something likegoogle/electra-base-generator - check the "slow" tests pass by running
RUN_SLOW=1 pytest tests/test_onnx_v2.py -k "electra" -rp
@lewtun Please check if it works. I handled what you commented. Thank you! |
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Thanks for making the changes @arron1227 ! I've left a final nit, but otherwise this looks great.
Before we merge, would you mind rebasing on master so that the merge conflicts are resolved?
Pinging @LysandreJik for his blessing on this PR 😇
…ra-onnx-support # Conflicts: # tests/test_onnx_v2.py
|
@lewtun |
|
Hey @arron1227 thanks for the rebase! It seems like we've picked up a lot of extra changes - do you mind if I fix this by making a commit on your branch? |
|
@lewtun |
| "masked-lm", | ||
| "causal-lm", |
There was a problem hiding this comment.
FYI I added these additional features that were missing in the PR
* electra is added to onnx supported model * add google/electra-base-generator for test onnx module Co-authored-by: Lewis Tunstall <lewis.c.tunstall@gmail.com>
3 participants
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.