Build the doc in a seperate folder then move it#16020
Conversation
| git pull && | ||
| mv ../builder_dir/transformers . && | ||
| git status && |
There was a problem hiding this comment.
when I tried to replicate locally, I get this error
mishig$ pwd
/Users/mishig/Desktop/moon/moon-landing/repos/doc-build
mishig$ mv ~/Desktop/build_dir/transformers/ .
mv: rename /Users/mishig/Desktop/build_dir/transformers/ to ./transformers/: Directory not empty
| echo "No diff in the documentation." | ||
| fi && | ||
| git pull && | ||
| mv ../builder_dir/transformers . && |
There was a problem hiding this comment.
| mv ../builder_dir/transformers . && | |
| rm -rf ./transformers/master && | |
| mv ../builder_dir./transformers && |
There was a problem hiding this comment.
Tried with cp -r but will use this if it fails.
There was a problem hiding this comment.
on each build, the bundled js gets a unique name here as start-{ID}.js (compare it to dtsts verions where there is only one start-xyz.js file)
unlike rm -rf, with cp -r, they will pile up (although they would not cause any rendering issue; will just look noisy)
There was a problem hiding this comment.
Will adjust! Good point!
mishig25
left a comment
mishig25
left a comment
There was a problem hiding this comment.
if all the CI passes & everything look good in the respective repos, lgtm for me!
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Looks great to me, thanks for working on it @sgugger!
3 participants
What does this PR do?
To fix the issue pointed out in #16019 this removes the need for stashing by:
TODO: the dev job as well once the main job has been tested