PyTorch FSDP integration in Trainer#17099
Closed
pacman100 wants to merge 3 commits intohuggingface:mainfrom
Closed
PyTorch FSDP integration in Trainer#17099pacman100 wants to merge 3 commits intohuggingface:mainfrom
pacman100 wants to merge 3 commits intohuggingface:mainfrom
Conversation
make style and make quality are now compliant.
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
May 5, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Thanks a lot! This looks great to me, I would just like to be sure this doesn't break anything. For some reason the tests are not run, could you try pushing your branch in a new branch of the huggingface/transformers repo (not your fork)?
Contributor
Author
|
Opened a new PR on the branch of main repo instead of fork 17136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PyTorch recently upstreamed the Fairscale FSDP into PyTorch Distributed with additional optimizations. This PR is aimed at integrating it into Trainer API.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.