Update expected values in DecisionTransformerModelIntegrationTest#18016
Merged
ydshieh merged 1 commit intohuggingface:mainfrom Jul 5, 2022
Merged
Update expected values in DecisionTransformerModelIntegrationTest#18016ydshieh merged 1 commit intohuggingface:mainfrom
ydshieh merged 1 commit intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
edbeeching
approved these changes
Jul 4, 2022
Contributor
edbeeching
left a comment
edbeeching
left a comment
There was a problem hiding this comment.
This is due to this issue a user highlighted. One of the layers in the checkpoint should have been all zeros in order to match the original implementation, but it was not. I corrected the mistake but I had not considered the integration tests.
Thanks for fixing this @ydshieh.
viclzhu
pushed a commit
to viclzhu/transformers
that referenced
this pull request
Jul 18, 2022
…ggingface#18016) Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As the checkpoint is updated a few days ago.