Fix incorrect comments about atten mask for pytorch backend#18728
Merged
sgugger merged 3 commits intohuggingface:mainfrom Sep 23, 2022
Merged
Fix incorrect comments about atten mask for pytorch backend#18728sgugger merged 3 commits intohuggingface:mainfrom
sgugger merged 3 commits intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
Collaborator
|
I think it's more clear to change from |
Contributor
Author
I agree, this is better. |
ydshieh
force-pushed
the
fix-comment
branch
from
86f8c5a to
67e83b2
Compare
ydshieh
reviewed
Sep 23, 2022
| # effectively the same as removing these entirely. | ||
| attention_mask = attention_mask.to(dtype=self.dtype) # fp16 compatibility | ||
| attention_mask = (1.0 - attention_mask) * -10000.0 | ||
| attention_mask = (1.0 - attention_mask) * torch.finfo(self.dtype).min |
Collaborator
There was a problem hiding this comment.
CodeGen was added after #17306. So update it here along with the comment.
sgugger
approved these changes
Sep 23, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I found these comments do not match the actual behavior. In these comments we use
-10000.0to mask out elements beforesoftmaxbut the actual value used istorch.finfo(dtype).min.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.