Fix opt softmax small nit#19243
Merged
younesbelkada merged 2 commits intohuggingface:mainfrom Sep 29, 2022
Merged
Conversation
- Use the same logic as 1eb0953 for consistency
ydshieh
approved these changes
Sep 29, 2022
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
Thank you @younesbelkada :-)
younesbelkada
commented
Sep 29, 2022
|
The documentation is not available anymore as the PR was closed or merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dtype_attn_weightsis not defined outside the conditionif attention_mask is not None:which makes the modeling code prone to potential bugs. Also, the solution provided in XGLM - Fix Softmax NaNs when using FP16 #18057 is clearer so this PR addresses the same change to make the implementations consistent across models that suffers from the same Softmax issue.cc @ydshieh @sgugger
Can also confirm slow tests pass!