Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Nov 3, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for fixing, you rock!
Collaborator
Author
|
Sorry, I always missed the last piece. Added the final commit to fix |
sgugger
approved these changes
Nov 3, 2022
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
* Add skip_special_tokens=True in some doctest * For T5 * Fix for speech_to_text.mdx Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After PR #15775, we need to either update some expected values or specify
skip_special_tokens=True.I am not very comfortable to use
skip_special_tokens=TrueforPT_QUESTION_ANSWERING_SAMPLEindoc.py, as it might fail other tests. We will have to run the doctest manually to see if everything is fine.(A lazy way is not to use this argument, but just to update the expected values)
update
I launched doctest here. The tests with
ForQuestionAnsweringall pass, so we are good!