Skip to content

fix plbart doctest#20527

Merged
ydshieh merged 1 commit intomainfrom
fix_plbart_doctest
Dec 1, 2022
Merged

fix plbart doctest#20527
ydshieh merged 1 commit intomainfrom
fix_plbart_doctest

Conversation

@ydshieh
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh commented Dec 1, 2022

What does this PR do?

We need to update the expect output in doc example after PR #19980

@ydshieh ydshieh requested a review from sgugger December 1, 2022 10:10
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Dec 1, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@ydshieh ydshieh merged commit 876a9e0 into main Dec 1, 2022
@ydshieh ydshieh deleted the fix_plbart_doctest branch December 1, 2022 15:49
@soma2000-lang
Copy link
Copy Markdown
Contributor

@ydshieh @sgugger I just want to know how this PR works and why was the doctests failing earlier? Thanks in advance!

@ydshieh
Copy link
Copy Markdown
Collaborator Author

ydshieh commented Dec 5, 2022

As the PR description mentioned, PR #19980 changed PLBartTokenizer, and some expected outputs in the tests have to be updated.

@soma2000-lang
Copy link
Copy Markdown
Contributor

@ydshieh got it. Thanks!

mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants