Skip to content

fix natten installation#20632

Merged
ydshieh merged 1 commit intomainfrom
fix_natten_2
Dec 6, 2022
Merged

fix natten installation#20632
ydshieh merged 1 commit intomainfrom
fix_natten_2

Conversation

@ydshieh
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh commented Dec 6, 2022

What does this PR do?

I made a mistake in #20546 and it ended up with

# For `dinat` model
RUN python3 -m pip install --no-cache-dir natten

RUN python3 -m pip install --no-cache-dir natten -f https://shi-labs.com/natten/wheels/$CUDA/

so the CUDA version was not installed (due to Requirement already satisfied)

@ydshieh ydshieh requested a review from sgugger December 6, 2022 20:01
RUN python3 -m pip install --no-cache-dir decord

# For `dinat` model
RUN python3 -m pip install --no-cache-dir natten
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this one, so the CUDA one could be installed.

Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Dec 6, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh merged commit f68796b into main Dec 6, 2022
@ydshieh ydshieh deleted the fix_natten_2 branch December 6, 2022 21:23
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants