Flax dtype-dependent numerical masking#21197
Merged
gante merged 4 commits intohuggingface:mainfrom Jan 19, 2023
Merged
Conversation
Contributor
Author
|
@sgugger this solution was discussed on Slack with the Flax team, hence no added Flax reviewers :) |
sgugger
approved these changes
Jan 19, 2023
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
LGTM!, Thanks for the fix!
|
The documentation is not available anymore as the PR was closed or merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21176
For some models, our Flax numerical masking was incompatible with the desired variable type. This PR fixes it by selecting a numerical mask that is the minimum for the corresponding variable type.
This PR is akin to #17306 for PT. Thank you @LysandreJik and @ydshieh for pointing it out 🙏