Generate: save generation config with the models' .save_pretrained()#21264
Merged
gante merged 1 commit intohuggingface:mainfrom Jan 23, 2023
Merged
Generate: save generation config with the models' .save_pretrained()#21264gante merged 1 commit intohuggingface:mainfrom
.save_pretrained()#21264gante merged 1 commit intohuggingface:mainfrom
Conversation
gante
changed the title
save_pretrained.save_pretrained()
5 tasks
ArthurZucker
approved these changes
Jan 23, 2023
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM thanks for adding this functionality 😉 As discussed, this should solve most of the issues I had
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Jan 23, 2023
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for adding this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As originally discussed in #20388, this PR makes
model.save_pretrained()also callmodel.generation_config.save_pretrained()if it is a generation-capable model (on all 3 frameworks).It also adds a bunch of tests, namely:
model.save_pretrained()actually savesgeneration_config.jsonif it is a model that can generate (on all 3 frameworks)