Skip to content

Fix OwlViTForObjectDetection.image_guided_detection doc example#23370

Merged
ydshieh merged 1 commit intomainfrom
fix_owlvit_doctest
May 15, 2023
Merged

Fix OwlViTForObjectDetection.image_guided_detection doc example#23370
ydshieh merged 1 commit intomainfrom
fix_owlvit_doctest

Conversation

@ydshieh
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh commented May 15, 2023

What does this PR do?

Need to update expected values after #23157

@ydshieh ydshieh requested review from alaradirik and amyeroberts May 15, 2023 11:55
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented May 15, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Copy Markdown
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - that's a big difference 👀

Thanks for fixing!

@ydshieh
Copy link
Copy Markdown
Collaborator Author

ydshieh commented May 15, 2023

@amyeroberts I know you actually want to give the approval but forgot doing it 😅 .
As I am a serious man, I would try not to merge without a format approval 🙏

Copy link
Copy Markdown
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ydshieh You're right - my bad :D All approved now 👍

@ydshieh ydshieh merged commit c94f7a1 into main May 15, 2023
@ydshieh ydshieh deleted the fix_owlvit_doctest branch May 15, 2023 12:17
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
…ggingface#23370)

fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…ggingface#23370)

fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants