Register ModelOutput class with PyTorch's pytree#25360
Closed
wconstab wants to merge 1 commit intohuggingface:mainfrom
Closed
Register ModelOutput class with PyTorch's pytree#25360wconstab wants to merge 1 commit intohuggingface:mainfrom
wconstab wants to merge 1 commit intohuggingface:mainfrom
Conversation
Summary: PyTree lets users flatten arbitrarily complex py data structures (e.g. ModelOutput) and operate over a flat list of their constituent parts. Users could opt to register HF's ModelOutput with pytree manually and then use it, but many users would not know to do this or would be inconvenienced by it. A common use case is to operate over all the tensors in a model's output. Test Plan: I've added a unit test but haven't run it locally (yet as it depends on PT and TF) - would check if CI runs it first. Reviewers: Subscribers: Tasks: Tags:
5 tasks
Collaborator
|
Was superseded by #25358 as discussed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
PyTree lets users flatten arbitrarily complex py data structures (e.g. ModelOutput) and operate over a flat list of their constituent parts.
Users could opt to register HF's ModelOutput with pytree manually and then use it, but many users would not know to do this or would be inconvenienced by it.
A common use case is to operate over all the tensors in a model's output.
Test Plan:
I've added a unit test but haven't run it locally (yet as it depends on PT and TF) - would check if CI runs it first.
Reviewers:
Subscribers:
Tasks:
Tags:
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.