Skip to content

Revert "Reuse the cache created for latest main on PRs/branches if setup.py is not modified"#25466

Merged
ydshieh merged 1 commit intomainfrom
revert-25445-rework_cache_again
Aug 11, 2023
Merged

Revert "Reuse the cache created for latest main on PRs/branches if setup.py is not modified"#25466
ydshieh merged 1 commit intomainfrom
revert-25445-rework_cache_again

Conversation

@ydshieh
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh commented Aug 11, 2023

Reverts #25445

The way to solve the whole huge cache issue is to enable cache sharing between PRs from different forked repositories, see this doc.

If we decide to enable this (it's a dangerous take), then we can include the #25445 once the sharing is done.

More info: https://circleci.com/docs/oss/#pass-secrets-to-builds-from-forked-pull-requests

…`setup.py` is not modified (#25445)"

This reverts commit 1d75768.
@ydshieh ydshieh requested a review from sgugger August 11, 2023 16:05
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Aug 11, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then!

@ydshieh ydshieh merged commit fe3c8ab into main Aug 11, 2023
@ydshieh ydshieh deleted the revert-25445-rework_cache_again branch August 11, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants