Skip to content

Skip test_contrastive_generate for TFXLNet#25574

Merged
ydshieh merged 2 commits intomainfrom
skip_tf_xlnet_contrastive
Aug 17, 2023
Merged

Skip test_contrastive_generate for TFXLNet#25574
ydshieh merged 2 commits intomainfrom
skip_tf_xlnet_contrastive

Conversation

@ydshieh
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh commented Aug 17, 2023

What does this PR do?

This model has special cache mechanism and test_contrastive_generate fails for more than 8 month. When I remove the argument penalty_alpha from the kwargs, it is able to generate something.

@ydshieh ydshieh requested a review from gante August 17, 2023 15:54
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Aug 17, 2023

The documentation is not available anymore as the PR was closed or merged.

@ydshieh
Copy link
Copy Markdown
Collaborator Author

ydshieh commented Aug 17, 2023

For the record, it starts to fail on commit a6c850e4 (#20994) but with a different error TypeError: prepare_inputs_for_generation() got multiple values for keyword argument 'use_cache'. Then in #21149, we get the current error.

Copy link
Copy Markdown
Contributor

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing 👍

@ydshieh ydshieh merged commit 427adc8 into main Aug 17, 2023
@ydshieh ydshieh deleted the skip_tf_xlnet_contrastive branch August 17, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants